Properly indicate failure in the rebuild command #2466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rebuild command triggered an assertion on failure in debug modes when splitting old heterogeneous partitions, and it turned out that we did not properly handle the failure case. This changes the rebuild command to show an error if it did not succeed, detailing to the user what went wrong.
dominiklohmann
force-pushed
the
story/sc-35816/rebuild-indicator-failure
branch
from
90d5535 to
a500611
Compare
patszt
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rebuild command triggered an assertion on failure in debug modes when splitting old heterogeneous partitions, and it turned out that we did not properly handle the failure case. This changes the rebuild command to show an error if it did not succeed, detailing to the user what went wrong.
📝 Checklist
🎯 Review Instructions
I've attached a small database with one heterogeneous partitions that can be used for reproducing the error. I did this by modifying the
applyhandler of the index to always return an error.📁 vast.db.archive.zip