-
-
Notifications
You must be signed in to change notification settings - Fork 99
Add memory-usage to index and catalog telemetry reports #2471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good to go, just a few types need a real memusage
instead of a bare sizeof
.
changelog/unreleased/features/2471--memory-usage-metrics-for-catalog-and-index.md
Outdated
Show resolved
Hide resolved
This also needs an update to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise this looks good to me.
52ec659
to
60ad854
Compare
As suggested by @tobim it would be beneficial to have some memory usage being reported in the telemetry.
The measurement is not precise but it can still help when looking for a memory leak
📝 Checklist
🎯 Review Instructions