Skip to content

Add memory-usage to index and catalog telemetry reports #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 5, 2022

Conversation

patszt
Copy link
Contributor

@patszt patszt commented Jul 28, 2022

As suggested by @tobim it would be beneficial to have some memory usage being reported in the telemetry.
The measurement is not precise but it can still help when looking for a memory leak

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on vast.io, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

@patszt patszt added the feature New functionality label Jul 28, 2022
@patszt patszt marked this pull request as ready for review July 28, 2022 10:50
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go, just a few types need a real memusage instead of a bare sizeof.

@tobim
Copy link
Member

tobim commented Aug 26, 2022

This also needs an update to web/docs/setup-vast/monitor.md.

@patszt patszt requested a review from tobim August 29, 2022 12:29
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise this looks good to me.

@patszt patszt merged commit 291c279 into master Sep 5, 2022
@patszt patszt deleted the story/sc-35008 branch September 5, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants