Lower the impact of low-priority queries #2484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes low-priority queries to be less meaningful for scheduling: Only 1/25th of a regular query, and 1/100th of a query used for parititon transformations. I'm hoping that this reduces the timeouts for compaction we've been seeing while many queries were active.
dominiklohmann
force-pushed
the
story/sc-35405/query-prio-adjustment
branch
from
5b6d648 to
2be2a50
Compare
dominiklohmann
force-pushed
the
story/sc-35405/query-prio-adjustment
branch
from
68c1605 to
e994fbe
Compare
dominiklohmann
force-pushed
the
story/sc-35405/query-prio-adjustment
branch
from
e994fbe to
99bb04f
Compare
lava
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes low-priority queries to be less meaningful for scheduling: Only 1/25th of a regular query, and 1/100th of a query used for partition transformations. I'm hoping that this reduces the timeouts for compaction we've been seeing while many queries were active.
📝 Checklist
🎯 Review Instructions
Run it to see if we still run into timeouts under stress.I deployed this on Callisto and the changes were visible as soon as compaction triggered the next time (after 1h with our current configuration). This is working nicely.