Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect --connection-timeout in more places #2503

Merged
merged 7 commits into from
Aug 22, 2022

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Aug 17, 2022

This expands on the work from #2499 and adds support for the new option to some additional places.

📝 Reviewer Checklist

Review this pull request by ensuring the following items:

  • All user-facing changes have changelog entries
  • User-facing changes are reflected on vast.io

@dominiklohmann dominiklohmann requested a review from mavam August 17, 2022 05:23
@dominiklohmann dominiklohmann force-pushed the story/sc-36392/connection-timeout-part-2 branch from a2799ff to 8a07bda Compare August 17, 2022 05:27
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall.

libvast/src/system/node.cpp Show resolved Hide resolved
libvast/src/system/node_control.cpp Show resolved Hide resolved
libvast/src/system/node.cpp Outdated Show resolved Hide resolved
@lava lava added the blocked Blocked by an (external) issue label Aug 17, 2022
@dominiklohmann dominiklohmann force-pushed the story/sc-36392/connection-timeout-part-2 branch from 8a17b57 to ff7a054 Compare August 18, 2022 08:18
@dominiklohmann dominiklohmann changed the base branch from master to story/sc-36459/fmt-9-support August 18, 2022 08:18
@dominiklohmann dominiklohmann force-pushed the story/sc-36392/connection-timeout-part-2 branch from ff7a054 to ff18ebd Compare August 18, 2022 08:33
@dominiklohmann dominiklohmann added the bug Incorrect behavior label Aug 18, 2022
Base automatically changed from story/sc-36459/fmt-9-support to master August 19, 2022 10:17
@lava lava removed the blocked Blocked by an (external) issue label Aug 22, 2022
@dominiklohmann dominiklohmann merged commit a5316e2 into master Aug 22, 2022
@dominiklohmann dominiklohmann deleted the story/sc-36392/connection-timeout-part-2 branch August 22, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants