-
-
Notifications
You must be signed in to change notification settings - Fork 98
Activate cloud plugins explicitely #2510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Starts off #2473, so requires it to be merged first |
43772bc
to
8e40b50
Compare
9f29769
to
82de3b8
Compare
cc50c6f
to
37fccd7
Compare
82de3b8
to
e6fb8f2
Compare
37fccd7
to
ab2ff87
Compare
Apart from this review, we can discuss about many readme.MD and other documentation files under different folders which makes it really hard to follow. We can just have 1 documentation file including everything. Additionally, the .env.example template should have following keys as well. These are referenced in aws-pro and can cause confusion.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to initialize and destroy pro environment. The issue with environment variables documentation will be followed in another story.
I commented on changelog entry for a typo.
ab2ff87
to
27f5fc6
Compare
Change described in https://app.shortcut.com/tenzir/story/36533/fix-the-way-cloud-plugins-are-loaded
📝 Reviewer Checklist
Review this pull request by ensuring the following items:
Reviewer instructions
main.py
contains the new plugin loading logic, so it is a good starting point for the code review itselfdeploy
,deploy-step
,destroy
anddestroy-step
methods are now fit to deploy/destroy any module, so we removed themodule_name.deploy
andmodule_name.destroy
commands in modules such asflowlogs
andcloudtrail