Wait until all stores have exited before finishing a partition transform #2543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lava
force-pushed
the
story/sc-37028/partition-transformer-race
branch
from
8adadf9 to
1931fbb
Compare
dominiklohmann
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
The implementation looks good to me.
I think this bug existed since before v2.2, so please add a changelog entry as well.
@patszt confirmed out of band that this fixes the issue in his setup that reliably reproduced it, so I did not do any additional manual testing.
Will do so in the rc4 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Reviewer Checklist
Review this pull request by ensuring the following items: