Remove the shutdown grace period #2568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
commented
Sep 8, 2022
dominiklohmann
force-pushed
the
story/sc-36673/terminator-no-hard-kill-attempt
branch
from
b4792a5 to
44153df
Compare
This removes the `vast.shutdown-grace-period` functionality and its underlying mechanism. This has two reasons: 1. The mechanism was broken, and in case of yet unpersisted data taking longer than the grace period to persist on shutdown caused both data loss and an infinite hang. 2. It is the purpose of a service manager to issue hard kills to hanging process, not of the hanging process itself. Ultimately we decided that the internal hard kill causes more issues than it helps solves, so now the new grace period is infinite: VAST simply waits for as long as it takes to shut down properly.
dominiklohmann
force-pushed
the
story/sc-36673/terminator-no-hard-kill-attempt
branch
from
44153df to
ccfef54
Compare
mavam
reviewed
Sep 8, 2022
mavam
approved these changes
Sep 8, 2022
dominiklohmann
deleted the
story/sc-36673/terminator-no-hard-kill-attempt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
vast.shutdown-grace-periodfunctionality and its underlying mechanism. This has two reasons:The mechanism was broken, and in case of yet unpersisted data taking longer than the grace period to persist on shutdown caused both data loss and an infinite hang.
It is the purpose of a service manager to issue hard kills to hanging process, not of the hanging process itself.
Ultimately we decided that the internal hard kill causes more issues than it helps solves, so now the new grace period is infinite: VAST simply waits for as long as it takes to shut down properly.
📝 Reviewer Checklist
Review this pull request by ensuring the following items: