Add simple docker-compose file #2574
Conversation
| services: | ||
| vast: | ||
| container_name: tenzir-vast | ||
| image: tenzir/vast:${VAST_VERSION:-latest} |
There was a problem hiding this comment.
Where did the build section go?
build:
context: .There was a problem hiding this comment.
I observed that even if we provide "image:..", docker-compose always starts building rather than pulling. This is not an expected behaviour, I wouldnt expect a docker-compose file in root folder to directly build when latest release is in DockerHub. We can put it back but it will increase the CI and local debugging time.
Let me know if there are alternatives we can use in docker-compose to fix this behaviour.
There was a problem hiding this comment.
If you put the pull_policy: build alongside the build into an override file for building you get the out-of-the-box experience that we were looking for: By default you pull, and you can opt-in to building by using the build file.
There was a problem hiding this comment.
pull_policy also affects docker run and everytime tests try to docker compose run a VAST client, it tries to pull/build.
I removed the build instructions from docker-compose and included them in documentation if anyone needs to build. Behaviour seems to have side effects and complicates.
If you think we should lean towards this a bit more, I can check further. docker-compose should be easy. Building is an optional action most likely to be taken by developers/contributors.
There was a problem hiding this comment.
If you put the pull_policy: build alongside the build into an override file for building you get the out-of-the-box experience that we were looking for: By default you pull, and you can opt-in to building by using the build file.
Please read again—I actually got it to work as expected with this.
|
I'll be picking this work up in a new PR that builds upon the changes to the Docker workflow I made in #2585. |
This PR adds a simple docker-compose file with VAST and integrates tests with Github CI.
📝 Reviewer Checklist
Review this pull request by ensuring the following items:
Also note that:
docker-composeversion in CI is not explicitly provided.docker-composehas no build instructions to keep it simple. Contributors/developers can use it withdocker buildanddocker-composedocker-compose up -dshould bring a working VAST server up and user should be able to spawn VAST clients bydocker-compose run ..