Move the version string into a central JSON file #2582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 3.24 is available for Debian bullseye, so we don't need to get it with pip. We also do this now in the Dockerfile in preparation of bumping the minimum beyond 3.18.
tobim
force-pushed
the
topic/version-json
branch
from
7580288 to
72fd64b
Compare
|
@tobim I'm fine with the idea generally. Can you re-request the review once all the CI workflows ran through, or should I be taking a look at this now already? |
Some tools might be interested in that data and scraping it from CMake code isn't the greatest approach.
tobim
force-pushed
the
topic/version-json
branch
from
72fd64b to
879f065
Compare
|
CI is green now. |
dominiklohmann
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake is not the only tool that is interested in the version string, so we move it into a format that is widely supported.
Note that the value of
vast-version-fallbackis not prefixed with 'v', because it is easier to add where needed than to remove when undesired.In order to allow this change, the minimum required CMake version is bumped from 3.18 to 3.19.
📝 Reviewer Checklist
Review this pull request by ensuring the following items: