Attempt to fix the static binary build for the web plugin #2614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: tobim@tenzir.com
lava
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
I think @tobim still had some open questions about whether it makes sense to always use our own CMakeLists for restinio so we can avoid the custom http-parser workarounds that the static build uses, but in the meantime this solution seems to work well enough.
tobim
reviewed
Oct 7, 2022
tobim
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to check if the regular CI build works with this fix.
📝 Reviewer Checklist
Review this pull request by ensuring the following items: