Skip to content

Abort the response promise if running into oversized partitions #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2022

Conversation

lava
Copy link
Member

@lava lava commented Oct 12, 2022

Previously calls to the apply handler of the index would hang
indefinitely, since the promise never got delivered.

📝 Reviewer Checklist

Review this pull request by ensuring the following items:

  • All user-facing changes have changelog entries
  • User-facing changes are reflected on vast.io

lava added 3 commits October 12, 2022 13:26
Previously calls to the `apply` handler of the index would hang
indefinitely, since the promise never got delivered.
@lava lava added the bug Incorrect behavior label Oct 12, 2022
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lava lava merged commit c89c614 into master Oct 13, 2022
@lava lava deleted the story/sc-38413/oversized-partition-fallback branch October 13, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants