-
-
Notifications
You must be signed in to change notification settings - Fork 95
Add a basic frontend to the web plugin #2638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a basic frontend to the web plugin #2638
Conversation
Seems like |
b180379
to
9685f6a
Compare
I tried to locally build from this branch but CMake Error at plugins/web/aux/CMakeLists.txt:20 (add_custom_command):
add_custom_command Wrong syntax. A TARGET or OUTPUT must be specified. |
@dit7ya This is caused by a missing bundled restinio (the error message is pretty terrible tbh), it should be solved by |
There are two |
Can you write a story for improving them? That should be easy enough to check ahead of assuming they exist. |
This commit migrates the state of tenzir/vast-frontend as of c88b0f71d into the web plugin.
You need to call `scripts/git-setup.sh -f` to install the update.
189f2a3
to
755a3d5
Compare
Update: Fixed by commit below :-) When I don't have any record in VAST, I get the following error:
The UI shows the VAST server as not running where it's actually running, just in the CLI I gets solved after importing a few records. It's so cool to have a webUI, even if it's just status page for now :-) |
@netantho Thanks for the feedback. I have pushed commits which should fix them. Since the frontend is at the very basic state right now, a lot of things are yet to be implemented - which should prevent this kind of bugs. |
Thanks @dit7ya! I confirm that your fixes for both of the bugs I found and reported :-) |
I have figured out some issues in the CI for this PR and fixing them on #2656. I am going to push some of those changes, and also going to probably rebase this on latest master, if there is no objection. |
5faaefa
to
fbd5857
Compare
97079ee
to
ad9f7e4
Compare
ad9f7e4
to
cbaf966
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally and the static binary package now comes with a nice web ui! 🥳
One extra note because you can't comment on files in GitHub:
This adds lock files for both yarn and pnpm, do we really need both?
…grate-frontend-web
CMake is a bit weird about subdirectories that install things when the parent directory does not use the install command at all. The easiest solution here is to just move things up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add SBOM entries for Frontend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side this is good to go as well but I went ahead and also merged #2681 into this PR so we atomically have the SBOM changes when we add the frontend code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This really deserves a changelog entry before it gets merged. @dit7ya do you want me to write one?
Yes, that would be great @tobim. On a sepatate note, macOS CI still seems unhappy 😭. |
I think this is an unrelated bug that somehow reached |
I pushed a fix for that @tobim, see comment in that PR. |
This PR adds a built-in web front end to the
web
plugin.It can be opened at the root of the HTTP server.
For example with this in your
vast.yaml
:You can point your browser to http://127.0.0.1:5657 to find the app.
📝 Reviewer Checklist
Review this pull request by ensuring the following items: