Remove PyVAST in favor of new Python bindings #2674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new Python bindings supersede the old PyVAST. There's no sense in keeping the code around with the new Python bindings being included with the next VAST release. PyVAST will continue to work as-is, but no new versions after v2.4 will be released anymore.
dominiklohmann
force-pushed
the
story/sc-38327/remove-pyvast
branch
from
9744721 to
0ca1586
Compare
mavam
approved these changes
Oct 29, 2022
Co-authored-by: Matthias Vallentin <matthias@vallentin.net>
|
It was never in the Nix scaffolding or the Dockerfile to begin with (unlike the new bindings). I did git-grep and believe I caught them all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Python bindings supersede the old PyVAST. There's no sense in keeping the code around with the new Python bindings being included with the next VAST release. PyVAST will continue to work as-is, but no new versions after v2.4 will be released anymore.
📝 Reviewer Checklist
Review this pull request by ensuring the following items: