Arrow 10.0.0 support #2685
Merged
Arrow 10.0.0 support #2685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 4, 2022 16:13
dominiklohmann
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Just one minor request for the changelog entry. We also need to bump nixpkgs (@tobim), and then I think this can be shipped.
Co-authored-by: Dominik Lohmann <mail@dominiklohmann.de>
Dakostu
force-pushed
the
story/sc-38757-arrow-10-support
branch
from
24147b1 to
b102e91
Compare
The commit we're using (b8869e373) is not merged to master yet, but it is highly likely that it or a variation of it will land eventually.
dominiklohmann
changed the title
tobim
force-pushed
the
story/sc-38757-arrow-10-support
branch
from
296a2c2 to
961c68d
Compare
Dakostu
commented
Nov 8, 2022
There was a problem hiding this comment.
@tobim So I ran Cmake on this this branch using an Arrow-9-based and an Arrow-10-based machine and they both succeeded. Building w/ Arrow 9 worked, I'm still building w/ Arrow 10, gonna assume both builds will run correctly...
I did leave one question though.
tobim
force-pushed
the
story/sc-38757-arrow-10-support
branch
from
961c68d to
027ba25
Compare
tobim
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support building VAST against Arrow 10.0.0.
📝 Reviewer Checklist
Review this pull request by ensuring the following items: