Rename vast dump to vast show
#2686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're planning to do more with the mostly internal command in the near future, and to quote @lava on the matter: > I wanna take the opportunity to suggest renaming `vast dump` to `vast > show`, since `dump` sounds like some kind of backup or debug command. I very much agree with that sentiment. This change implements the transition without any deprecation period as the command is not even documented currently and I do not anticipate anyone actually depending on it.
dominiklohmann
force-pushed
the
story/sc-32781/dump-to-show
branch
from
eb0377d to
a53aef2
Compare
patszt
approved these changes
Nov 8, 2022
tobim
force-pushed
the
story/sc-38757-arrow-10-support
branch
from
961c68d to
027ba25
Compare
|
Not strictly required for this PR, but upcoming documentation will go to https://vast.io/docs/use/introspect, right? |
That I will leave up to you. Just waiting for the Arrow PR to be merged now so CI gets fixed on this one. |
|
I believe this PR was missing a |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're planning to do more with the mostly internal command in the near future, and to quote @lava on the matter:
I very much agree with that sentiment. This change implements the transition without any deprecation period as the command is not even documented currently and I do not anticipate anyone actually depending on it.
📝 Reviewer Checklist
Review this pull request by ensuring the following items: