Load "all" plugins by default & allow "empty" values #2689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is makes the OOTB experience so much better! |
Dakostu
force-pushed
the
story/sc-38995
branch
from
08a12cf to
02645f3
Compare
Dakostu
force-pushed
the
story/sc-38995
branch
2 times, most recently
from
599148f to
8850239
Compare
Dakostu
changed the title
|
@tobim can I ask you to take the review from here on out? |
2 tasks
tobim
approved these changes
Nov 16, 2022
added 15 commits
November 16, 2022 14:16
added 16 commits
November 16, 2022 14:18
…o anonymous namespace" This reverts commit 8850239.
Dakostu
force-pushed
the
story/sc-38995
branch
from
e9938fa to
c30abf5
Compare
dominiklohmann
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
This is great, just some smaller things left to do. I also added a blocked label to prevent this from being merged accidentally in the feature freeze for v2.4; whether this gets in regardless is up to @lava.
changelog/unreleased/changes/2689--load-all-plugins-by-default.md
Outdated
Show resolved
Hide resolved
|
Since the first rc will be tagged rc2 anyways we decided to squeeze this in in today's standup. |
dominiklohmann
added a commit
that referenced
this pull request
Nov 18, 2022
This is a code base cleanup related to #2689. Historically speaking, "native plugins" were functionality that was part of libvast but used the plugin API. This allowed us to have defaults that we ship as built-in functionality. The only reason why we did not name them builtins from the get-go was because the term builtin was too close to the term bundled, which we already used for plugins that were built alongside VAST in the same build configuration (via `-DVAST_PLUGINS=...`). Now that bundled plugins are a purely internal term we can instead start referring to native plugins as builtins. In addition, this changes the show command to be a built-in instead without making any functional changes to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load "all" plugins if no "plugins" configuration key is defined in the configuration.
📝 Reviewer Checklist
Review this pull request by ensuring the following items: