-
-
Notifications
You must be signed in to change notification settings - Fork 95
Make it easy to create docker images with Nix #2742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is not a drop-in replacement for the existing tenzir/vast image, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried testing it with
➜ nix run github:tenzir/vast/topic/flake-docker-image#stream-image | docker load
but
➜ docker run -dt --name=vast --rm tenzir/vast start
f2d5f2f1ece9b652cd6b5c8d52c31319b2dcc764deaec28a6e3fd89525bb548f
docker: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "start": executable file not found in $PATH: unknown.
Probably due to NixOS/nixpkgs#99760
Edit: See suggestion below.
With the config changes I just added there are only 3 remaining differences:
|
if you want to drop the existing tenzir/vast image, I would recommend using the nix2container as an image builder instead. smaller granularity -> example? also tested with the podman. |
I tested |
I don't think we want to drop the regular image, as that supports mounting in additional plugins. This one doesn't. I'm still all for calling this vast-slim. |
8231d46
to
1b9757c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my point of view this is all good to go. @tobim, please take a look through the changes I've made before merging.
f0dd59b
to
8061f98
Compare
This can be used with ``` nix run .#stream-image | docker load ``` It reuses the regular static binary output so it won't rebuild VAST if the static binary is already available. According to `docker image ls` the resulting image wheighs 117 Mb, significantly lighter than the Debian based image which is ~330 Mb.
The `vast-static` package now has a dedicated `package` output that contains the `tar.gz` and `deb` installable packages.
A bug in the CMake macro to strip the install prefix from specific installation dirs triggered an unwanted rebuild of libvast as part of the packaging step.
a66be13
to
053f936
Compare
Authored-by: Benno Evers <benno.evers@tenzir.com>
59eeb21
to
55daf16
Compare
This can be used with
It reuses the regular static binary output so it won't rebuild VAST if the static binary is already available.
According to
docker image ls
the resulting image weighs 117 Mb,significantly lighter than the Debian based image which is ~330 Mb.