Skip to content

Merge the type-registry into the catalog #2745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Dec 10, 2022
Merged

Merge the type-registry into the catalog #2745

merged 17 commits into from
Dec 10, 2022

Conversation

Dakostu
Copy link

@Dakostu Dakostu commented Nov 28, 2022 •
edited by dominiklohmann
Loading

This merged the functionality of the type-registry into the catalog, in preparation for a future refactoring where type information is solely maintained based on the available partitions.

@Dakostu Dakostu added the refactoring Restructuring of existing code label Nov 28, 2022
@Dakostu Dakostu requested a review from a team November 28, 2022 15:55
@Dakostu Dakostu changed the title Merge type_registry with catalog... Merge type_registry into the catalog... Nov 28, 2022
@dominiklohmann dominiklohmann mentioned this pull request Nov 29, 2022
Merged
dominiklohmann
dominiklohmann approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this already. Just got some minor feedback and requests inline.

I'll also add a blocked label, this should only be merged after the VAST v2.4 release.

@dominiklohmann dominiklohmann added the blocked Blocked by an (external) issue label Nov 29, 2022
@Dakostu
Copy link
Author

Dakostu commented Nov 30, 2022

[sc-39810]

Daniel Kostuj and others added 17 commits December 8, 2022 15:52
Move type_registry and type_registry_state to catalog.{hpp,cpp}
52db6f3
Fuse type_registry and catalog
e58fbeb
Align lambda captures in catalog handlers
c4a60dc
Refresh some old references to the type-registry
782269c
Fix formatting in catalog.cpp
32c4af8
Add an index to catalog test fixture
6f364df
Make catalog taxonomy test use the index
14c397c
@dominiklohmann
Change catalog parameter description in source.hpp
1efb1b5 
Co-authored-by: Dominik Lohmann <mail@dominiklohmann.de>
@dominiklohmann
Add a missing apostrophe in catalog.hpp
569282a 
Co-authored-by: Dominik Lohmann <mail@dominiklohmann.de>
Rename catalog_state loading/saving methods to {load,save}_type_regis…
4c90506 
…try...
Align catalog_state method definition order to method declaration order
4ce2963
Remove unused includes in catalog.cpp
035ec0e
Remove unused includes in catalog.hpp
aae3be5
Change 'dir' catalog parameter to 'type_reg_dir'
05a3226
Add a changelog item
387fd85
Apply a simple reformatting
2a4f686
Remove catalog_state::status()
e4ec5b9
@dominiklohmann dominiklohmann changed the title Merge type_registry into the catalog... Merge the type-registry into the catalog Dec 10, 2022
@dominiklohmann dominiklohmann removed the blocked Blocked by an (external) issue label Dec 10, 2022
@dominiklohmann dominiklohmann merged commit 40d4eaa into master Dec 10, 2022
@dominiklohmann dominiklohmann deleted the story/sc-32113 branch December 10, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
refactoring Restructuring of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dakostu @dominiklohmann