Infer non-config types in extend and replace operators #2768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
topic/extend-replace-type-infer
branch
from
076dc23 to
b664fa1
Compare
dominiklohmann
commented
Dec 7, 2022
dispanser
approved these changes
Dec 8, 2022
dominiklohmann
added
blocked
dominiklohmann
force-pushed
the
topic/extend-replace-type-infer
branch
from
b664fa1 to
97ecf65
Compare
Previously, using an address value in the extend or replace operators did not work. This is now fixed, and will produce the proper type as long as it can be inferred from the data. This bug applied to all types that were not also used as types in configuration, i.e., address, subnet, pattern, and map.
dominiklohmann
force-pushed
the
topic/extend-replace-type-infer
branch
from
97ecf65 to
c9591fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using an address value in the extend or replace operators did not work. This is now fixed, and will produce the proper type as long as it can be inferred from the data. This bug applied to all types that were not also used as types in configuration, i.e., address, subnet, pattern, and map.