Implement support for :string == /pattern/ queries
#2769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a noisy warning for queries like `http.hostname ~ /.*\.com$/`, which actually do work like expected despite being _really_ slow because we instantiate the regular expression for every individual element instead of doing that only once.
The match operator was something we never really implemented in its entirety, and it also just doesn't make sense to have. `:string == /pattern/` and `:string in /pattern/` already are a superset of its functionality. Since it was broken anyways this doesn't warrant a deprecation period or us rewriting expressions dynamically.
dominiklohmann
commented
Dec 7, 2022
3 tasks
mavam
approved these changes
Dec 7, 2022
This change makes it so we only instantiate regex objects once per batch instead of once per row, causing a massive speedup even for simple pattern searches.
dominiklohmann
added
blocked
This change makes it so we only instantiate regex objects once per batch instead of once per row, causing a massive speedup even for simple pattern searches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to VAST for queries of field extractors against patterns. It also removes support for the redundant match operator, which was broken in many ways.
Querying a pattern always does a full scan of all partitions for which the field extractor bound, and there is some further room for optimization still: The current implementation actually goes to the relevant sparse and dense indexes instead of skipping them outright. That would require a larger refactoring of accessing dense and sparse indexes based on the three-tuple of
(lhs, op, rhs)rather than justlhsin a normalized predicate.