Remove the #field meta extractor
#2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/sc-28660/remove-field-extractor
branch
from
c1aab7c to
a271ada
Compare
dominiklohmann
force-pushed
the
story/sc-28660/remove-field-extractor
branch
from
759782b to
5f6ca5e
Compare
The predicate `#field == "X"` matched all events for which the field extractor `X` had data, i.e., it was semantically equivalent to `X != nil`. Fundamentally, the `#field` meta extractor broke our model of extractors, since it did not result in a single value or a list of values to compare against, but rather create an implicit disjunction with changed relational operator semantics compared to all other predicates. This removes the operator without a deprecation period as it received very little usage.
dominiklohmann
force-pushed
the
story/sc-28660/remove-field-extractor
branch
from
6ded662 to
357fa54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The predicate
#field == "X"matched all events for which the field extractorXhad data, i.e., it was semantically equivalent toX != nil.Fundamentally, the
#fieldmeta extractor broke our model of extractors, since it did not result in a single value or a list of values to compare against, but rather created an implicit disjunction with changed relational operator semantics compared to all other predicates.This removes the operator without a deprecation period as it received very little usage.