Remove outdated table slice encodings #2798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the introduction of a minimum partition version of 1 with #2778, we're no longer able to encounter any table slices that are MessagePack-encoded or use an older version of the mapping of our data model onto Apache Arrow. There's a future refactoring that is now unblocked, which is a total replacement of the legacy baggage that is the `table_slice` API with an easier-to-use wrapper around the same underlying data that makes more assumptions about the underlying column-major memory layout. This is based on #2797 to avoid merge conflicts.
We've removed the Broker plugin—it was written for Zeek 3.x and never worked with newer versions. It's dependencies were also troublesome to get them working with CAF 0.18. The real-time Zeek import will return in a future plugin by connecting to Zeek directly via a websocket
mavam
approved these changes
Dec 15, 2022
The process was the following:
The one thing |
Bump CAF to version 0.18.6
…ve-old-table-slice-encodings
dominiklohmann
deleted the
story/sc-39999/remove-old-table-slice-encodings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the introduction of a minimum partition version of 1 with #2778, we're no longer able to encounter any table slices that are MessagePack-encoded or use an older version of the mapping of our data model onto Apache Arrow.
There's a future refactoring that is now unblocked, which is a total replacement of the legacy baggage that is the
table_sliceAPI with an easier-to-use wrapper around the same underlying data that makes more assumptions about the underlying column-major memory layout.This is based on #2797 to avoid merge conflicts.