Make feather stores read incrementally #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes `feather` stores not to use the official Apache Feather reader anymore, but rather use its lower-level building blocks to do reads incrementally. This means that loading a feather store should not take any time anymore; the actual reading only happens on demand as batches are accessed. This is implemented in a way that the store caches already read batches so they're not read again for concurrent queries. NB: This technically drops support for reading Apache Feather V1 files, but VAST never wrote them to begin with and we never officially said we support that.
dominiklohmann
commented
Dec 17, 2022
mavam
reviewed
Dec 18, 2022
dominiklohmann
force-pushed
the
topic/feather-incremental-read
branch
from
76c07f3 to
9e261fc
Compare
mavam
approved these changes
Dec 19, 2022
I added a note at the bottom that we plan to make the same improvement for our Parquet stores. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
featherstores not to use the official Apache Feather reader anymore, but rather use its lower-level building blocks to do reads incrementally. This means that loading a feather store should not take any time anymore; the actual reading only happens on demand as batches are accessed. This is implemented in a way that the store caches already read batches so they're not read again for concurrent queries.NB: This technically drops support for reading Apache Feather V1 files, but VAST never wrote them to begin with and we never officially said we support that.