-
-
Notifications
You must be signed in to change notification settings - Fork 98
Implement a retry mechanism for VAST clients failing to connect to the server #2835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is there, nice. I think we can gut out the code a bit to make it simpler.
@patszt can you please update the user-facing docs as well at the section where it would make sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor requests, and then I think we soon got it. 🚀
217290c
to
00c075b
Compare
9e83d56
to
84cfc35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works really nicely in practice. Just some really minor stuff remaining. Great work, Patryk! 🙏
changelog/unreleased/features/2835--retry-mechanism-for-vast-clients.md
Outdated
Show resolved
Hide resolved
cb17f78
to
8a520c7
Compare
I have done a simple test to check the retry mechanism.
Run export -> wait a 2 - 3 seconds and run vast start.
Previously the client exits with error:
Now it manages to export the data.