Change boolean literals to true and false
#2844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/sc-15839/boolean-literal-true-false
branch
from
0bf9e65 to
19c8f1c
Compare
dominiklohmann
force-pushed
the
story/sc-15839/boolean-literal-true-false
branch
from
19c8f1c to
ab64727
Compare
mavam
approved these changes
Jan 10, 2023
changelog/unreleased/breaking-changes/2844--boolean-literals-true-false.md
Outdated
Show resolved
Hide resolved
Historically, VAST used the literals `T` and `F` to denote true and false values. This change switches to `true` and `false` instead, which are much more widely used—essentially everywhere. I asked for feedback on this in the community Slack and this appeared to be a much appreciated change. Given that the next release is a major release this is without a deprecation period. It also changes the printing dual of booleans in VAST's native export format "ascii" to `true` and `false` accordingly.
dominiklohmann
force-pushed
the
story/sc-15839/boolean-literal-true-false
branch
from
ab64727 to
5211129
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, VAST used the literals
TandFto denote true and false values. This change switches totrueandfalseinstead, which are much more widely used—essentially everywhere.I asked for feedback on this in the community Slack and this appeared to be a much appreciated change. Given that the next release is a major release this is without a deprecation period. It also changes the printing dual of booleans in VAST's native export format "ascii" to
trueandfalseaccordingly.