Move event distribution statistics to the catalog #2852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
commented
Jan 11, 2023
Setting `-D VAST_ENABLE_UPDATE_INTEGRATION_REFERENCES=ON` while configuring the build will now cause running the integration tests to update the baseline for you.
dominiklohmann
force-pushed
the
story/sc-40408/schema-stats-in-catalog
branch
2 times, most recently
from
2d5acb1 to
4ec14d5
Compare
dominiklohmann
force-pushed
the
story/sc-40408/schema-stats-in-catalog
branch
from
4ec14d5 to
fa23067
Compare
dit7ya
reviewed
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the event distribution statistics from the index to the catalog. In a way this is a breaking change: The statistics now only count passive partitions, but since we plan to remove support for querying active partitions anyways it's in line with our envisioned architecture. It is also one further thing that the index and partition transformer need to maintain about partitions.
What previously required
vast status --detailed indexis now visible invast status catalogwith some additional information, namely the number of partitions for a given schema name and the newest and oldest import timestamp.As an added bonus, this also removes the offset from the active partition and the partition synopsis, as this was guaranteed to be zero, and deprecates the field in the corresponding FlatBuffers table. That is not user-facing at all, essentially just a clean-as-you-go kind of change.