Skip to content

Fix linux PID file check on startup #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 15, 2023
Merged

Fix linux PID file check on startup #2861

merged 3 commits into from
Jan 15, 2023

Conversation

lava
Copy link
Member

@lava lava commented Jan 13, 2023

This check seems to have at some point been converted from sprintf to fmt::format without adjusting the syntax. (although its a bit surprising that fmt doesn't throw a compile error here)

@lava lava added the bug Incorrect behavior label Jan 13, 2023
mavam
mavam approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wowza... I also would have expected a compile-time error here.

@lava @mavam
Fix changelog typos
8dc5269 
Co-authored-by: Matthias Vallentin <matthias@vallentin.net>
@lava lava enabled auto-merge January 13, 2023 16:50
@lava lava merged commit 8cae830 into master Jan 15, 2023
@lava lava deleted the topic/pidfile-handling branch January 15, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lava @mavam