Rename count, int, real, and addr to uint64, int64, double, and ip respectively #2864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
feature
dominiklohmann
force-pushed
the
story/sc-40551/rename-basic-types
branch
4 times, most recently
from
6f16425 to
7100706
Compare
dominiklohmann
force-pushed
the
story/sc-40551/rename-basic-types
branch
3 times, most recently
from
4df3c8f to
f847244
Compare
dominiklohmann
force-pushed
the
story/sc-40551/rename-basic-types
branch
from
f847244 to
2b4e8de
Compare
This change makes it such that `-1 < 0u` correctly returns false rather true in query evalaution. Queries cannot run into this yet due to the lack of type coercion, but with the switch from `vast::integer` to `int64_t` clang (rightfully) started emitting warnings about this.
dominiklohmann
force-pushed
the
story/sc-40551/rename-basic-types
branch
from
2b4e8de to
3042f23
Compare
mavam
approved these changes
Jan 15, 2023
See #2865. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the basic type names of the
count,int,real, andaddrtypes touint64,int64,double, andip. It also changes the type extractors accordingly.The change is written in a way that is backwards-compatible: the old type tokens are still recognized and parsed by VAST, and a warning is omitted once per deprecated type token on startup if it is parsed.
This PR does intentionally not change the identifier of the Arrow extension type for the
iptype fromvast.addresstovast.ip, as that is a breaking change that while possible to implement requires a lot of effort. If we want to change that we can always do so in the future, but I intentionally spared myself from it for this PR.Most of this renaming was created semi-automatically through the help of clangd and
:lua vim.lsp.buf.rename(), and some clever git-grepping in combination with quickfix lists and:cdo s/old/new/g. I don't expect this to be thoroughly reviewed, as I don't think this is possible given the number of changes. Please do look at the documentation changes.