Remove the pattern type
#2873
Merged
Remove the pattern type
#2873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
topic/remove-the-pattern-type
branch
4 times, most recently
from
e8b7096 to
57afa56
Compare
This follows up on the removal of the match operator and introduction of pattern search using predicates of the form `lhs == /rhs/` by removing the pattern type without replacement. In theory this is a hard and incompatible breaking change. However, we know of no single user that has relied upon the pattern type being available, and as such it _should_ be safe to be removed without a transparent upgrade path. To make clear just how unlikely it is that anyone ran into this: users would've had to have a field of type `pattern #index=skip` in their schema, as attempting to index a pattern field crashed because we never actually implemented support for it, which was (1) never documented and (2) nobody ever complained about it.
dominiklohmann
force-pushed
the
topic/remove-the-pattern-type
branch
from
57afa56 to
34932de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on the removal of the match operator and introduction of pattern search using predicates of the form
lhs == /rhs/by removing the pattern type without replacement.In theory this is a hard and incompatible breaking change. However, we know of no single user that has relied upon the pattern type being available, and as such it should be safe to remove it without a transparent upgrade path.
To make clear just how unlikely it is that anyone ran into this: users would've had to have a field of type
pattern #index=skipin their schema, as attempting to index a pattern field crashed because we never actually implemented support for it, which was (1) never documented and (2) nobody ever complained about it.