Make the map type inaccessible to users #2976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to remove the map type, but doing that is a larger operation. To get the user-facing breaking change out earlier, i.e., in time for 3.0, we're just making it inaccessible first and are then removing it later on.
This was the only place in VAST that ever used the map type for table
slices written to disk: The `vast.metrics` event, whose metadata was
never queryable.
Now, behold the beauty of actually queryable metrics from the self-sink:
```
$ vast -qq export json '#type == "vast.metrics.passive-store.init.runtime"
| select ts,value
| summarize min(value), max(value) by ts resolution 10s'
{"ts": "2023-02-28T17:21:50.000000", "min(value)": 0.218875, "max(value)": 107.280125}
{"ts": "2023-02-28T17:20:00.000000", "min(value)": 0.549292, "max(value)": 0.549292}
```
To enable the self-sink for testing, set the following:
```yaml
# <prefix>/etc/vast/vast.yaml
vast:
enable-metrics: true
metrics:
self-sink:
enable: true
```
|
Loving the "self sink" example! |
Co-authored-by: Matthias Vallentin <matthias@vallentin.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to remove the map type, but doing that is a larger operation. To get the user-facing breaking change out earlier, i.e., in time for 3.0, we're just making it inaccessible first and are then removing it later on.
Additionally, this PR removes the only place in VAST that ever used the map type for table slices written to disk: The
vast.metricsevent, whose metadata was never queryable.Now, behold the beauty of actually queryable metrics from the self-sink:
To enable the self-sink for testing, set the following: