Skip to content

Fix infinite recursion in the record algebra parser #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2023
Merged

Fix infinite recursion in the record algebra parser #2977

merged 3 commits into from
Mar 1, 2023

Conversation

tobim
Copy link
Member

@tobim tobim commented Feb 28, 2023

Fixes parsing of

type broken = record {
  test: : string
}

as reported by @satta.

@tobim tobim added the bug Incorrect behavior label Feb 28, 2023
@satta
Copy link
Contributor

satta commented Feb 28, 2023

That was fast, thanks :)

tobim added 2 commits March 1, 2023 17:00
@tobim
Test parsing an invalid legacy type
46be2df 
This test causes an infinite recursion in the record algebra
parsing logic.
@tobim
Fix infinite recursion in the record algebra parser
fbb02ca 
This parser was able to recurse without consuming any characters.
@tobim tobim force-pushed the topic/infinite-recursion-in-record-algebra-parser branch from 2878c77 to fbb02ca Compare March 1, 2023 16:00
@tobim tobim marked this pull request as ready for review March 1, 2023 16:38
dominiklohmann
dominiklohmann approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing a test for this as well.

@tobim tobim enabled auto-merge March 1, 2023 16:40
@tobim tobim merged commit b43eebc into master Mar 1, 2023
@tobim tobim deleted the topic/infinite-recursion-in-record-algebra-parser branch March 1, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobim @satta @dominiklohmann