-
-
Notifications
You must be signed in to change notification settings - Fork 96
Update query endpoint to use new pipeline executor #3015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caa9b2f
to
ad6fb58
Compare
794d5bb
to
24987da
Compare
This commit also adds `logical_operator::predicate_pushdown`.
24987da
to
1ae39c5
Compare
Due to incomplete support by the current CI compilers.
The `put` operator is a replacement for both the `extend` and the `replace` operators. It takes as arguments a comma-separated list of assignments. If the assigned-to extractor resolves for the input data replaces all occurences of the field (previously `replace`), and if the extractor does not resolve adds one new field at the end (previously `extend`). `put` is the first operator not to be available in the old pipeline operator framing, and as such is not currently reachable by the user.
dominiklohmann
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great piece of work. I tested it out extensively locally as part of the put
PR (which is based on this).
Approving as-is, but I've got one minor thing that I think we could change or write a follow-up issue for.
Co-authored-by: Jannis Christopher Köhl <mail@koehl.dev>
The `put` operator is a replacement for both the `extend` and the `replace` operators. It takes as arguments a comma-separated list of assignments. If the assigned-to extractor resolves for the input data replaces all occurences of the field (previously `replace`), and if the extractor does not resolve adds one new field at the end (previously `extend`). `put` is the first operator not to be available in the old pipeline operator framing, and as such is not currently reachable by the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
/query
REST endpoint to use the new pipeline API. This also means that queries are not allowed to start with an expression. Usewhere
instead.It also adds
operator_base::predicate_pushdown
such that queries such aswhere x == 1 | where y == 2 | head 5
are optimized intohead 5
, with an additionalx == 1 && y == 2
constraint that is passed to the index.