Skip to content

Include outdated but not undersized partitions in automatic rebuilds #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 16, 2023
Merged

Include outdated but not undersized partitions in automatic rebuilds #3020

merged 4 commits into from
Mar 16, 2023

Conversation

dominiklohmann
Copy link
Member

This fixes a bug where automatic rebuilds picked up undersized and outdated partitions, but not outdated partitions that were appropriately sized.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Mar 16, 2023
@dominiklohmann dominiklohmann requested a review from tobim March 16, 2023 12:27
@dominiklohmann dominiklohmann force-pushed the topic/rebuild-outdated-but-not-undersized branch from 58b2c6e to 87fe9c6 Compare March 16, 2023 12:33
tobim
tobim requested changes Mar 16, 2023
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution seems to have an oversight in the logic. Can you check it again?

@dominiklohmann dominiklohmann mentioned this pull request Mar 16, 2023
Merged
tobim
tobim approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that this works as expected now with a vast database created with v2.2.

@dominiklohmann dominiklohmann disabled auto-merge March 16, 2023 17:26
@dominiklohmann dominiklohmann merged commit 8a28f5c into main Mar 16, 2023
@dominiklohmann dominiklohmann deleted the topic/rebuild-outdated-but-not-undersized branch March 16, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @tobim