Skip to content

Add unique operator #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 12, 2023
Merged

Add unique operator #3051

merged 4 commits into from
Apr 12, 2023

Conversation

jachris
Copy link
Contributor

@jachris jachris commented Mar 31, 2023

No description provided.

@jachris jachris force-pushed the topic/unique-operator branch from 5105228 to 0c80432 Compare March 31, 2023 12:00
@jachris jachris added the feature New functionality label Mar 31, 2023
@jachris jachris force-pushed the topic/unique-operator branch 5 times, most recently from 6e09571 to 1f8b3de Compare April 3, 2023 07:55
@jachris jachris changed the title WIP: Add unique operator Add unique operator Apr 3, 2023
@jachris jachris marked this pull request as ready for review April 3, 2023 07:56
@jachris jachris requested a review from a team April 3, 2023 07:56
@jachris jachris requested review from a team and removed request for a team April 11, 2023 15:41
dominiklohmann
dominiklohmann approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The algorithm makes sense to me, and we already have a follow-up issue to track implementing this in a column-major way. For now this works well enough, I think.

@jachris jachris force-pushed the topic/unique-operator branch from 769f7fd to a7ed066 Compare April 12, 2023 12:53
@jachris jachris enabled auto-merge April 12, 2023 12:54
@jachris jachris merged commit 7e4c9c8 into main Apr 12, 2023
@jachris jachris deleted the topic/unique-operator branch April 12, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jachris @dominiklohmann