-
-
Notifications
You must be signed in to change notification settings - Fork 99
Implement the measure
operator
#3093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2a87092
to
c6d6481
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One general comment: You could consider renaming this operator, because inspect
is not the most intuitive name for its behavior. Perhaps even something like metrics
(although we'd normally avoid nouns). But you can also keep it as-is.
@mavam do you have an idea for a better name? I agree generally that
|
TBH, although I absolutely prefer verbs as well, we should not put this requirement above everything else. If there is no adequate verb, we should just use a noun. And we already do this with |
I agree that
|
Of the suggested alternatives I chose to go with |
inspect
operatormeasure
operator
The `inspect [--real-time]` operator emits metrics about the input into the pipeline. The operator handles both events and bytes as input, and emits the metrics as events as described by these schemas, respectively: ``` type vast.inspect.events = record { timestamp: time, schema: string, events: uint64, } type vast.inspect.bytes = record { timestamp: time, bytes: uint64, } ``` The `--real-time` option causes the operator to instantly emit the metrics at the cost of throughput.
5d8b98a
to
9cdf261
Compare
The
measure [--real-time]
operator emits metrics about the input into the pipeline. The operator handles both events and bytes as input, and emits the metrics as events as described by these schemas, respectively:The
--real-time
option causes the operator to instantly emit the metrics at the cost of throughput.