Skip to content

Extend file loader to file loader+saver #3097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 25, 2023
Merged

Extend file loader to file loader+saver #3097

merged 6 commits into from
Apr 25, 2023

Conversation

Dakostu
Copy link

@Dakostu Dakostu commented Apr 25, 2023

This PR extends the file loader to a basic file IO by adding saver_plugin functionality to the file plugin.

@Dakostu Dakostu added the feature New functionality label Apr 25, 2023
dominiklohmann
dominiklohmann approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We peer-reviewed this.

@Dakostu Dakostu enabled auto-merge April 25, 2023 09:13
@Dakostu Dakostu merged commit 778e38c into main Apr 25, 2023
@Dakostu Dakostu deleted the topic/file-saver branch April 25, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

@jachris jachris Awaiting requested review from jachris

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dakostu @dominiklohmann