Skip to content

Implement the import operator #3128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2023
Merged

Implement the import operator #3128

merged 4 commits into from
May 17, 2023

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented May 7, 2023

The import operator is a remote event sink for a pipeline that imports events into VAST.

This current implementation is very basic, and simply forwards events to the existing importer singleton component in the VAST node.

In the future, we should change the import operator to directly create passive partitions, and to send then to the catalog directly, which will enable better fault tolerance. That, however, is a change we can make in the future, as VAST's internal APIs are not well suited for that at the current point in time.

Tasks

Preview Give feedback

@dominiklohmann dominiklohmann added the feature New functionality label May 7, 2023
@dominiklohmann dominiklohmann force-pushed the topic/import-operator branch 4 times, most recently from 41a5ba6 to da4ee4a Compare May 15, 2023 15:25
@jachris jachris self-requested a review May 17, 2023 09:06
@dominiklohmann dominiklohmann force-pushed the topic/import-operator branch 3 times, most recently from e5d6213 to 980bf64 Compare May 17, 2023 10:26
@dominiklohmann dominiklohmann marked this pull request as ready for review May 17, 2023 10:29
@dominiklohmann dominiklohmann force-pushed the topic/import-operator branch from 980bf64 to 0bec5d8 Compare May 17, 2023 10:30
Copy link
Contributor

@jachris jachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dominiklohmann dominiklohmann enabled auto-merge May 17, 2023 15:19
The `import` operator is a remote event sink for a pipeline that imports
events into VAST.

This current implementation is very basic, and simply forwards events to
the existing `importer` singleton component in the VAST node.

In the future, we should change the `import` operator to directly create
passive partitions, and to send then to the catalog directly, which will
enable better fault tolerance. That, however, is a change we can make in
the future, as VAST's internal APIs are not well suited for that at the
current point in time.

To make testing easier, this also implements a `repeat` operator that
repeats an input (either bytes or events) a given number of times.
Sometimes with metrics you only care about the accumulated total, but
want to see that updating live. This is what `measure --cumulative`
gives you: a running total of events or bytes going into the operator.
@dominiklohmann dominiklohmann force-pushed the topic/import-operator branch from 2978989 to 7c63193 Compare May 17, 2023 16:52
@dominiklohmann dominiklohmann merged commit 6b52e9e into main May 17, 2023
@dominiklohmann dominiklohmann deleted the topic/import-operator branch May 17, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants