-
-
Notifications
You must be signed in to change notification settings - Fork 96
Implement the import
operator
#3128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
commented
May 8, 2023
41a5ba6
to
da4ee4a
Compare
e5d6213
to
980bf64
Compare
980bf64
to
0bec5d8
Compare
jachris
approved these changes
May 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
The `import` operator is a remote event sink for a pipeline that imports events into VAST. This current implementation is very basic, and simply forwards events to the existing `importer` singleton component in the VAST node. In the future, we should change the `import` operator to directly create passive partitions, and to send then to the catalog directly, which will enable better fault tolerance. That, however, is a change we can make in the future, as VAST's internal APIs are not well suited for that at the current point in time. To make testing easier, this also implements a `repeat` operator that repeats an input (either bytes or events) a given number of times.
Sometimes with metrics you only care about the accumulated total, but want to see that updating live. This is what `measure --cumulative` gives you: a running total of events or bytes going into the operator.
2978989
to
7c63193
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
import
operator is a remote event sink for a pipeline that imports events into VAST.This current implementation is very basic, and simply forwards events to the existing
importer
singleton component in the VAST node.In the future, we should change the
import
operator to directly create passive partitions, and to send then to the catalog directly, which will enable better fault tolerance. That, however, is a change we can make in the future, as VAST's internal APIs are not well suited for that at the current point in time.Tasks