Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align endpoints between regular and slim Docker images #3137

Merged

Conversation

dominiklohmann
Copy link
Member

These now both use 0.0.0.0:<default-port> instead of 127.0.0.1:<default-port>, unless the user explicitly sets the VAST_ENDPOINT environment variable. Previously, only the tenzir/vast-slim images did this.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label May 10, 2023
@dominiklohmann dominiklohmann requested a review from tobim May 10, 2023 07:56
These now both use `0.0.0.0:<default-port>` instead of
`127.0.0.1:<default-port>`, unless the user explicitly sets the
`VAST_ENDPOINT` environment variable. Previously, only the
`tenzir/vast-slim` images did this.
@dominiklohmann dominiklohmann force-pushed the topic/align-endpoints-between-vast-and-vast-slim branch from 0de03d0 to ed0ec42 Compare May 10, 2023 07:58
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@dominiklohmann dominiklohmann merged commit c6f6e40 into main May 10, 2023
@dominiklohmann dominiklohmann deleted the topic/align-endpoints-between-vast-and-vast-slim branch May 10, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants