Skip to content

Add the enumerate operator #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 16, 2023
Merged

Add the enumerate operator #3142

merged 15 commits into from
May 16, 2023

Conversation

mavam
Copy link
Member

@mavam mavam commented May 11, 2023 •
edited
Loading

This PR adds enumerate as operator.

  • Implement
  • Document
  • Make field name configurable
  • Add tests

@mavam mavam force-pushed the topic/enumerate branch from 05d4879 to 121a3fa Compare May 11, 2023 15:01
dominiklohmann
dominiklohmann reviewed May 11, 2023
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still like to see some tests, and have some remarks on the code, but this is mostly ready to go I think.

@mavam mavam force-pushed the topic/enumerate branch from 8cc7151 to 3bea99b Compare May 15, 2023 11:07
@mavam mavam requested a review from dominiklohmann May 15, 2023 11:08
dominiklohmann
dominiklohmann approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last comments, but other than that I think this is ready to go.

dominiklohmann
dominiklohmann reviewed May 15, 2023
View reviewed changes
@mavam mavam force-pushed the topic/enumerate branch from b993f58 to 574ba7f Compare May 15, 2023 18:03
@mavam mavam requested a review from dominiklohmann May 15, 2023 18:04
dominiklohmann
dominiklohmann approved these changes May 16, 2023
View reviewed changes
dominiklohmann
dominiklohmann reviewed May 16, 2023
View reviewed changes
@mavam mavam enabled auto-merge May 16, 2023 06:48
@mavam mavam merged commit c5c9f67 into main May 16, 2023
@mavam mavam deleted the topic/enumerate branch May 16, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mavam @dominiklohmann