Skip to content

Fix remaining partitions counter in the rebuilder #3147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 12, 2023
Merged

Fix remaining partitions counter in the rebuilder #3147

merged 3 commits into from
May 12, 2023

Conversation

dominiklohmann
Copy link
Member

This fixes a few things around rebuild statistics, in particular the rebuilder.partitions.remaining metric and the
rebuild.statistics.remaining field in the output of vast status rebuild:

  • Fixed a bug where the rebuilder dereferenced an invalidated iterator into the list of catalog lookup results when no partitions for one schema needed to be rebuilt. This bug only affected metrics, but not the actual partitions used for the rebuilding.
  • Removed a trigger for rebuilder metrics that caused metrics to be emitted twice when done, or before some partitions that did not need to be rebuilt were pruned from the list of partitions.

@dominiklohmann
Fix remaining partitions counter in the rebuilder
9fa3845 
This fixes a few things around rebuild statistics, in particular the
`rebuilder.partitions.remaining` metric and the
`rebuild.statistics.remaining` field in the output of `vast status
rebuild`:

- Fixed a bug where the rebuilder dereferenced an invalidated iterator
  into the list of catalog lookup results when no partitions for one
  schema needed to be rebuilt. This bug only affected metrics, but not
  the actual partitions used for the rebuilding.
- Removed a trigger for rebuilder metrics that caused metrics to be
  emitted twice when done, or before some partitions that did not need
  to be rebuilt were pruned from the list of partitions.
@dominiklohmann dominiklohmann added the bug Incorrect behavior label May 12, 2023
dominiklohmann and others added 2 commits May 12, 2023 09:58
@dominiklohmann @mavam
Improve wording
e8f14b7 
Co-authored-by: Matthias Vallentin <matthias@vallentin.net>
@dominiklohmann
Add a changelog entry
083a8b0
@dominiklohmann dominiklohmann enabled auto-merge May 12, 2023 08:39
@dominiklohmann dominiklohmann disabled auto-merge May 12, 2023 09:17
@dominiklohmann dominiklohmann merged commit 366b4c2 into main May 12, 2023
@dominiklohmann dominiklohmann deleted the topic/rebuild-fixes-remaining-counter branch May 12, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @mavam