Skip to content

Add a --cumulative option to the measure operator #3156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2023

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented May 17, 2023

Sometimes with metrics you only care about the accumulated total, but want to see that updating live. This is what measure --cumulative gives you: a running total of events or bytes going into the operator.

@dominiklohmann dominiklohmann requested a review from a team May 17, 2023 11:09
@dominiklohmann dominiklohmann force-pushed the topic/measure-incremental branch from 721232e to fd065da Compare May 17, 2023 11:10
@mavam
Copy link
Member

mavam commented May 17, 2023

You could call this --cumulative as well.

Sometimes with metrics you only care about the accumulated total, but
want to see that updating live. This is what `measure --cumulative`
gives you: a running total of events or bytes going into the operator.
@dominiklohmann dominiklohmann force-pushed the topic/measure-incremental branch from fd065da to ba2e201 Compare May 17, 2023 12:10
@dominiklohmann dominiklohmann changed the title Add a --incremental option to the measure operator Add a --cumulative option to the measure operator May 17, 2023
@dominiklohmann
Copy link
Member Author

Following quick agreement in Slack I renamed the option to --cumulative.

@jachris jachris requested review from jachris and removed request for a team May 17, 2023 14:43
@dominiklohmann dominiklohmann merged commit 2978989 into topic/import-operator May 17, 2023
@dominiklohmann dominiklohmann deleted the topic/measure-incremental branch May 17, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants