Skip to content

Implement the serve operator and /serve endpoint #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jun 1, 2023

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented May 30, 2023

The serve sink operator lifts the results of a pipeline into an endpoint that can be fetched from incrementally. Its corresponding /serve endpoint is the replacement of the existing /query endpoint.

Tasks

Preview Give feedback

@dominiklohmann dominiklohmann added the feature New functionality label May 30, 2023
@dominiklohmann dominiklohmann force-pushed the topic/serve-operator branch from 9157301 to 98b48e5 Compare May 31, 2023 11:09
The `serve` sink operator lifts the results of a pipeline into an
endpoint that can be fetched from incrementally. Its corresponding
`/serve` endpoint is the replacement of the existing `/query` endpoint.
@dominiklohmann dominiklohmann force-pushed the topic/serve-operator branch from 98b48e5 to e0c0977 Compare May 31, 2023 11:29
@dominiklohmann dominiklohmann force-pushed the topic/serve-operator branch from 6142ed6 to a8903c2 Compare May 31, 2023 16:23
@dominiklohmann dominiklohmann marked this pull request as ready for review May 31, 2023 16:23
@dominiklohmann dominiklohmann requested a review from Dakostu May 31, 2023 16:27
Copy link

@Dakostu Dakostu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played around with this and it seems to work, so: approval from me.

I did leave some comments though.

@dominiklohmann dominiklohmann enabled auto-merge June 1, 2023 14:19
@Dakostu Dakostu disabled auto-merge June 1, 2023 14:22
@dominiklohmann dominiklohmann enabled auto-merge June 1, 2023 14:28
@dominiklohmann dominiklohmann merged commit 39fe716 into main Jun 1, 2023
@dominiklohmann dominiklohmann deleted the topic/serve-operator branch June 1, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants