Skip to content

Fix shutdown of sources and importer #3207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Conversation

dominiklohmann
Copy link
Member

This fixes a shutdown issue for sources and the importer actor when the outbound source buffer was full and the remote node was shut down.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Jun 8, 2023
@dominiklohmann dominiklohmann requested a review from tobim June 8, 2023 12:38
Co-authored-by: Tobias Mayer <tobim@fastmail.fm>
@dominiklohmann dominiklohmann force-pushed the topic/importer-shutdown branch from 5533ccd to 013cf4e Compare June 8, 2023 12:40
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empirically verified.

@dominiklohmann dominiklohmann enabled auto-merge June 8, 2023 13:20
@dominiklohmann dominiklohmann merged commit 9086e24 into main Jun 8, 2023
@dominiklohmann dominiklohmann deleted the topic/importer-shutdown branch June 8, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants