Skip to content

Remove the prefix() function from the REST endpoint plugin API #3221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 14, 2023

Conversation

lava
Copy link
Member

@lava lava commented Jun 14, 2023

It turned out to be more complication than it was worth it; in particular it generated a mismatch between an endpoints external and internal name that could lead to bugs.

@lava lava added refactoring Restructuring of existing code bug Incorrect behavior labels Jun 14, 2023
@dominiklohmann dominiklohmann changed the title Remove the 'prefix()' function from the REST endpoint plugin API Remove the prefix() function from the REST endpoint plugin API Jun 14, 2023
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

@lava lava force-pushed the topic/rest-plugin-prefix branch 2 times, most recently from 740c061 to b6fa68f Compare June 14, 2023 12:43
@lava lava force-pushed the topic/rest-plugin-prefix branch from b6fa68f to e2fdc3a Compare June 14, 2023 12:56
@lava lava enabled auto-merge June 14, 2023 15:33
@lava lava merged commit 3ded209 into main Jun 14, 2023
@lava lava deleted the topic/rest-plugin-prefix branch June 14, 2023 17:57
@lava lava mentioned this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior refactoring Restructuring of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants