Skip to content

Revamp packet acquisition and parsing #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Jul 10, 2023
Merged

Revamp packet acquisition and parsing #3263

merged 39 commits into from
Jul 10, 2023

Conversation

mavam
Copy link
Member

@mavam mavam commented Jun 24, 2023 •
edited
Loading

This PR revamps the PCAP plugin under the new connector/format framework.

### Tasks
- [x] Add `pcap` parser
- [x] Add `pcap` printer
- [x] Add `nic` loader
- [x] Document everything
- [x] Add `decapsulate` operator
- [x] Write changelog entry
- [x] Support externally passed PCAP file header
- [x] Add tests

@mavam mavam force-pushed the topic/pcap-plugin-revamp branch 3 times, most recently from 8950816 to cc4f563 Compare June 27, 2023 03:40
@mavam mavam changed the title Revamp PCAP plugin Revamp packet acquisition and parsing Jun 27, 2023
@mavam mavam force-pushed the topic/pcap-plugin-revamp branch 3 times, most recently from 2f20148 to fa3c416 Compare June 27, 2023 16:18
@mavam mavam added format Parser and printer connector Loader and saver operator Source, transformation, and sink and removed enhancement labels Jul 2, 2023
@mavam mavam force-pushed the topic/pcap-plugin-revamp branch 4 times, most recently from c859b01 to 7bf0c4a Compare July 6, 2023 07:00
@mavam mavam added the feature New functionality label Jul 6, 2023
@mavam mavam force-pushed the topic/pcap-plugin-revamp branch 2 times, most recently from f7cb80e to a29640e Compare July 8, 2023 07:33
mavam
mavam commented Jul 8, 2023
View reviewed changes
Copy link
Member Author

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need some help from @tenzir/pipelines-squad, per the comment inline.

@mavam mavam force-pushed the topic/pcap-plugin-revamp branch from a29640e to 1fe896f Compare July 10, 2023 05:34
@mavam mavam force-pushed the topic/pcap-plugin-revamp branch from 200c92d to 9e03864 Compare July 10, 2023 05:56
@mavam mavam force-pushed the topic/pcap-plugin-revamp branch from 9e03864 to bbfa930 Compare July 10, 2023 06:05
@mavam mavam marked this pull request as ready for review July 10, 2023 06:06
dominiklohmann
dominiklohmann approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the office, I've simply pushed my review feedback directly onto your branch. From my side this is ready to go. Before merging, please take a look at the commits I've added.

@dominiklohmann dominiklohmann enabled auto-merge July 10, 2023 16:14
@dominiklohmann dominiklohmann merged commit 2f781d1 into main Jul 10, 2023
@dominiklohmann dominiklohmann deleted the topic/pcap-plugin-revamp branch July 10, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jachris jachris jachris left review comments

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
connector Loader and saver feature New functionality format Parser and printer operator Source, transformation, and sink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mavam @dominiklohmann @jachris