Delete delete_when_stopped from the pipeline manager
#3292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
approved these changes
Jul 3, 2023
jachris
force-pushed
the
topic/delete-delete-when-stopped
branch
from
0dc0055 to
fa7797d
Compare
jachris
force-pushed
the
topic/delete-delete-when-stopped
branch
from
fa7797d to
8f6ccc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
delete_when_stoppedpipeline manager flag. We want to access diagnostics if the pipeline fails during execution, but this is impossible if the pipeline is immediately deleted. Instead, we use TTL as the only mechanism for pipeline deletion (besides the explicit/pipeline/deleteendpoint).