Skip to content

Remove previously deprecated options #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Jul 13, 2023

The Tenzir v4.0 release is a major release. This change makes use of the opportunity to remove some previously deprecated options:

  • Remove option tenzir.pipelines (replaced with tenzir.operators)
  • Remove option tenzir.pipeline-triggers (no replacement)
  • Remove deprecated type tokens addr, count, int, and real (replaced with ip, uint64, int64, and double, respectively)
  • Remove support for reading from segment stores (read-only since VAST v2.3, migrated automatically over time to Feather and/or Parquet)

@dominiklohmann dominiklohmann added the maintenance Tasks for keeping up the infrastructure label Jul 13, 2023
@dominiklohmann dominiklohmann requested a review from tobim July 13, 2023 10:35
@dominiklohmann dominiklohmann force-pushed the topic/remove-deprecated-things branch from eb75fa1 to 08075ca Compare July 13, 2023 10:37
The Tenzir v4.0 release is a major release. This change makes use of the
opportunity to remove some previously deprecated options:
- Remove option `tenzir.pipelines` (replaced with `tenzir.operators`)
- Remove option `tenzir.pipeline-triggers` (no replacement)
- Remove deprecated type tokens `addr`, `count`, `int`, and `real`
  (replaced with `ip`, `uint64`, `int64`, and `double`, respectively)
This does not need a separate announcement: Writing segment store files
has been unsupported for over a year now. Let's also use this
opportunity of a major release to clean this up.
@dominiklohmann dominiklohmann force-pushed the topic/remove-deprecated-things branch from 08075ca to c2f2206 Compare July 13, 2023 12:35
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look too closely, the important stuff is covered by CI.

@dominiklohmann
Copy link
Member Author

Didn't look too closely, the important stuff is covered by CI.

That actually ended up finding one last missing list<int> that I just changed to list<int64>. Pushed that, should be ready to go now.

@dominiklohmann dominiklohmann enabled auto-merge July 13, 2023 13:47
@dominiklohmann dominiklohmann force-pushed the topic/remove-deprecated-things branch 2 times, most recently from 2cc1994 to c073938 Compare July 13, 2023 14:20
@dominiklohmann dominiklohmann force-pushed the topic/remove-deprecated-things branch from c073938 to b6f89d3 Compare July 13, 2023 15:00
@dominiklohmann dominiklohmann merged commit df295e3 into main Jul 13, 2023
@dominiklohmann dominiklohmann deleted the topic/remove-deprecated-things branch July 13, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants