Expose the batch operator underlying rebuild
#3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
feature
dominiklohmann
force-pushed
the
topic/rebatch
branch
from
44dcb60 to
8f12d0d
Compare
This takes the internal rebatching operator of the rebuild command and makes it available as the `batch <limit>` operator. This is particularly useful for formats like Feather or Parquet or connectors like Kafka.
This resolves a long-standing todo from the sort operator: We now rebatch its outputs transparently. In very much non-scientific measurements this increased the throughput of later operators in the pipeline significantly.
dominiklohmann
force-pushed
the
topic/rebatch
branch
from
7e458ab to
45090ee
Compare
mavam
approved these changes
Jul 24, 2023
I incorporated all the review feedback (thanks!) and added a few basic tests. I'll merge this into #3390 now to cut down on the number of CI runs I need to wait for as that is also already approved and the base of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the internal rebatching operator of the rebuild command and makes it available as the
batch <limit>operator. This is particularly useful for formats like Feather or Parquet or connectors like Kafka.Additionally, this resolves a long-standing todo from the
sortoperator: We now rebatch its outputs transparently. In very much non-scientific measurements this increased the throughput of later operators in the pipeline significantly.Note: to avoid merge conflicts this is based on #3390. I did want this to be reviewed separately, though.