Skip to content

Add show operator #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Aug 2, 2023
Merged

Add show operator #3414

merged 29 commits into from
Aug 2, 2023

Conversation

mavam
Copy link
Member

@mavam mavam commented Jul 28, 2023

This PR adds a show operator to introspect a node.

@mavam mavam added operator Source, transformation, and sink feature New functionality labels Jul 28, 2023
@mavam mavam force-pushed the topic/show-operator branch from a855d07 to fe1650c Compare July 30, 2023 11:37
@mavam mavam force-pushed the topic/show-operator branch from 3b650e7 to b0023fb Compare July 31, 2023 12:24
@mavam mavam marked this pull request as ready for review July 31, 2023 12:25
@mavam mavam requested a review from jachris July 31, 2023 12:25
@mavam
Copy link
Member Author

mavam commented Jul 31, 2023

Note to the reviewer:

  • show types is rough, but we marked the operator as "experimental" so we can make changes
  • I want a show tables ultimately, in addition to show partitions. In fact, I think show schemas is not what we want. Nearly all DBs have an equivalent of show tables.

jachris
jachris approved these changes Jul 31, 2023
View reviewed changes
mavam added 3 commits July 31, 2023 17:43
@mavam
Factor aspects into dedicated components
8d0ee16 
The single operator implementation got a bit too big. We now have the logic
separated. In the future, we can make these plugins if need be.
@mavam
Use proper contract for operator optimization
367d01b
@mavam
Adjust misclassified operator
e3027f2
@mavam mavam force-pushed the topic/show-operator branch from 08018d6 to e3027f2 Compare July 31, 2023 16:50
@mavam mavam enabled auto-merge August 2, 2023 13:12
@mavam mavam merged commit accad73 into main Aug 2, 2023
@mavam mavam deleted the topic/show-operator branch August 2, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann left review comments

@jachris jachris jachris approved these changes

Assignees
No one assigned
Labels
feature New functionality operator Source, transformation, and sink
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mavam @dominiklohmann @jachris