-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement compress
and decompress
operators
#3443
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
added
feature
New functionality
operator
Source, transformation, and sink
labels
Aug 7, 2023
The (intentionally) undocumented `discard` operator is mostly useful for benchmarking. This extends it to also accept bytes as input.
dominiklohmann
force-pushed
the
topic/compress-and-decompress
branch
2 times, most recently
from
August 8, 2023 21:14
7476679
to
bfb1ea7
Compare
`compress [--level <level>] <format>` and its dual `decompress [--level <level>] <format>` make it easy to work with compressed data in pipeline directly. This comes with support for all formats that Apache Arrow ships with and that support streaming compression and decompression. As of Arrow 12.0, the supported formats are `brotli`, `bz2`, `gzip`, `lz4`, and `zstd`.
dominiklohmann
force-pushed
the
topic/compress-and-decompress
branch
from
August 8, 2023 21:15
bfb1ea7
to
d76b1a6
Compare
mavam
reviewed
Aug 8, 2023
dominiklohmann
force-pushed
the
topic/compress-and-decompress
branch
from
August 9, 2023 15:55
5348be8
to
a23ad0f
Compare
Dakostu
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some quick compression-decompression tests with every codec and the operators are doing their job.
I say, let's ship it.
Of course I left some minor comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compress [--level <level>] <format>
and its dualdecompress <format>
make it easy to work with compressed data in pipeline directly.This comes with support for all formats that Apache Arrow ships with and that support streaming compression and decompression. As of Arrow 12.0, the supported formats are
brotli
,bz2
,gzip
,lz4
, andzstd
.Tasks